Skip to content

updates teardown to account for ddp #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2020
Merged

updates teardown to account for ddp #2389

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7141aea
remove warnings
williamFalcon Jun 27, 2020
ffe00f2
remove warnings
williamFalcon Jun 27, 2020
b6c52c6
added doc lines
williamFalcon Jun 28, 2020
1677e3f
added doc lines
williamFalcon Jun 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions pytorch_lightning/trainer/training_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,9 +410,6 @@ def train(self):
self.interrupted = True
self.on_keyboard_interrupt()

for proc in self.interactive_ddp_procs:
subprocess.Popen.kill(proc)

self.run_training_teardown()

def prepare_train_loop_dataloader(self, train_dataloader):
Expand Down Expand Up @@ -853,9 +850,7 @@ def run_training_teardown(self):
if hasattr(self, '_teardown_already_run') and self._teardown_already_run:
return

# clean up dist group
if self.use_ddp or self.use_ddp2:
torch_distrib.destroy_process_group()
self._teardown_already_run = True

# Train end events
with self.profiler.profile('on_train_end'):
Expand All @@ -869,8 +864,16 @@ def run_training_teardown(self):
self.logger.finalize("success")

# summarize profile results
self.profiler.describe()
self._teardown_already_run = True
if self.global_rank == 0:
self.profiler.describe()

if self.global_rank == 0:
for proc in self.interactive_ddp_procs:
subprocess.Popen.kill(proc)

# clean up dist group
if self.use_ddp or self.use_ddp2:
torch_distrib.destroy_process_group()

def training_forward(self, batch, batch_idx, opt_idx, hiddens):
"""
Expand Down