Fix min_max gpu memory logging bug #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
approved these changes
Nov 3, 2019
Collaborator
Borda
left a comment
Borda
left a comment
There was a problem hiding this comment.
looks fine, but some proper testing would be fine... (I understand that most free CI does not have GPU, so pls copy-paste results from your computer)
| for k, v in zip(range(len(gpu_memory)), gpu_memory): | ||
| k = f'gpu_{k}' | ||
| gpu_memory_map[k] = v | ||
| gpu_memory = [int(x) for x in result.stdout.strip().split('\n')] |
Collaborator
There was a problem hiding this comment.
instead of \n consider using os.sep
Contributor
Author
There was a problem hiding this comment.
Thanks for your feedback. I used os.linesep instead.
Contributor
Author
|
This is metrics logs of training with min_max gpu memory logging option.
|
Contributor
|
@dreamgonfly love the PR! thanks for the great submission. @Borda i run every PR through GPU tests btw. |
Collaborator
I know, but for those who do not have avalaible couple of GPUs it is better to ask the author to show it... if you do not mind :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #452
Additionally, this PR updates & simplifies some code.
subprocess.runas officially recommended by python docs (refer to https://docs.python.org/3/library/subprocess.html#using-the-subprocess-module)Did you have fun?
Yes :)