-
Notifications
You must be signed in to change notification settings - Fork 3.6k
simplify imports xla / TPU #4872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
approved these changes
Nov 26, 2020
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM !
Codecov Report
@@ Coverage Diff @@
## master #4872 +/- ##
======================================
Coverage 93% 93%
======================================
Files 118 118
Lines 8905 9004 +99
======================================
+ Hits 8282 8376 +94
- Misses 623 628 +5 |
rohitgr7
reviewed
Nov 26, 2020
rohitgr7
approved these changes
Nov 26, 2020
SeanNaren
approved these changes
Nov 26, 2020
SkafteNicki
approved these changes
Nov 26, 2020
williamFalcon
approved these changes
Nov 26, 2020
45f4382 to
11c06e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3rd party
Related to a 3rd-party
accelerator: tpu
Tensor Processing Unit
priority: 1
Medium priority task
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Partial #4859
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃