Skip to content

Conversation

@SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Nov 27, 2020

What does this PR do?

Fix parity test for sharded, it seems for multiple optimisers its too tight.

Fixes #4856

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added priority: 1 Medium priority task ci Continuous Integration labels Nov 27, 2020
@Borda Borda added this to the 1.1 milestone Nov 27, 2020
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM !

@Borda Borda added the ready PRs ready to be merged label Nov 28, 2020
@Borda Borda added the bug Something isn't working label Nov 29, 2020
@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #4884 (cbeb082) into master (597dfa1) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4884   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         121     121           
  Lines        9119    9119           
======================================
  Hits         8444    8444           
  Misses        675     675           

@SeanNaren SeanNaren merged commit df7a52d into master Nov 29, 2020
@SeanNaren SeanNaren deleted the feature/increase_parity branch November 29, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants