remove unused rpc import in modelcheckpoint causing import error #5198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
Borda,
SeanNaren,
justusschock,
tchaton and
williamFalcon
as code owners
awaelchli
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5198 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 134 134
Lines 9933 9932 -1
======================================
- Hits 9247 9246 -1
Misses 686 686 |
Collaborator
|
Can we clean all imports in this subpackage with isort? |
Contributor
Author
|
ok but it didn't really change anything :) |
Collaborator
well no we can remove this file from |
Collaborator
|
@awaelchli in fact we shall not ignore these :D will be reflected #5201 (this goes for 1.2) |
Contributor
Author
|
ok is it good now? |
Collaborator
|
for the isort you can use |
SeanNaren
approved these changes
Dec 20, 2020
rohitgr7
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5197
it looks like this import error is caused in pytorch < 1.7