Skip to content

Conversation

@sidhantls
Copy link
Contributor

@sidhantls sidhantls commented Jan 19, 2021

What does this PR do?

Sets add_help=False in the parent_parser of semantic_segmentation in pl_examples. A conflicting options error occurs when running through command line because add_help=True in both the parent parser and the parser adding model specific args. Either one of them can be set to False to fix the error and still display the help options

Fixes #5568

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #5569 (bb62f67) into master (486f682) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5569   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         135     135           
  Lines       10005   10005           
======================================
- Hits         9339    9332    -7     
- Misses        666     673    +7     

@carmocca carmocca added ready PRs ready to be merged bug Something isn't working example labels Jan 19, 2021
@Borda Borda enabled auto-merge (squash) January 19, 2021 14:40
@Borda Borda added this to the 1.1.x milestone Jan 19, 2021
@Borda Borda merged commit 3825ce4 into Lightning-AI:master Jan 19, 2021
@sidhantls sidhantls deleted the pl_examples branch January 20, 2021 04:22
Borda added a commit that referenced this pull request Feb 4, 2021
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working example ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

args error when running pl_examples semantic_segmentation through command line

7 participants