Skip to content

Conversation

@carmocca
Copy link
Contributor

What does this PR do?

Fixes #5577

To be removed with #5359

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

@carmocca carmocca added ready PRs ready to be merged docs Documentation related labels Jan 19, 2021
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #5578 (8c0da9b) into master (f477c2f) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5578   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         135     135           
  Lines       10005   10005           
======================================
  Hits         9339    9339           
  Misses        666     666           

@carmocca carmocca enabled auto-merge (squash) January 20, 2021 15:52
@Borda Borda removed the ready PRs ready to be merged label Jan 20, 2021
@Borda
Copy link
Collaborator

Borda commented Jan 20, 2021

ok, as this do not touch any code it seems that the failing tests are unrelated...

@Borda Borda added the ready PRs ready to be merged label Jan 20, 2021
@Borda Borda added this to the 1.1.x milestone Jan 20, 2021
@carmocca carmocca disabled auto-merge January 20, 2021 17:27
@carmocca carmocca merged commit 7abd822 into Lightning-AI:master Jan 20, 2021
@carmocca carmocca deleted the docs/5577 branch January 20, 2021 17:27
tchaton pushed a commit that referenced this pull request Feb 3, 2021
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda added a commit that referenced this pull request Feb 4, 2021
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
tchaton pushed a commit that referenced this pull request Feb 4, 2021
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda added a commit that referenced this pull request Feb 4, 2021
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda added a commit that referenced this pull request Feb 4, 2021
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda added a commit that referenced this pull request Feb 4, 2021
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a warning for returning none for from training_step using multi-GPU

5 participants