Skip to content

Conversation

@SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jun 5, 2021

What does this PR do?

There is a failing special test on master due to some of the port issues. I noticed that this seemed to be related to running two tests directly after each other for spawn/normal sharded ddp, thus split them out and added a todo. I also removed a hard-coded port setting.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the ci Continuous Integration label Jun 5, 2021
@SeanNaren SeanNaren self-assigned this Jun 5, 2021
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #7841 (f806a4a) into master (b093a9e) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7841    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         207     207            
  Lines       13378   13374     -4     
=======================================
- Hits        12248   11604   -644     
- Misses       1130    1770   +640     

@SeanNaren SeanNaren mentioned this pull request Jun 5, 2021
11 tasks
@tchaton
Copy link
Contributor

tchaton commented Jun 8, 2021

Hey @SeanNaren,

Any updates on this one ?

Best,
T.C

@SeanNaren SeanNaren marked this pull request as ready for review June 16, 2021 11:15
@SeanNaren SeanNaren changed the title [WIP] Try to fix DeepSpeed CI Fix Special Tests Jun 16, 2021
@SeanNaren SeanNaren added this to the v1.3.x milestone Jun 16, 2021
@Borda Borda enabled auto-merge (squash) June 16, 2021 13:24
@SeanNaren
Copy link
Contributor Author

Let's merge as is to get the special tests working. I'm having difficulty getting it to work with random ports for some weird whacky reason...

@Borda Borda merged commit 55494e8 into master Jun 16, 2021
@Borda Borda deleted the fix/deepspeed_ci branch June 16, 2021 17:39
awaelchli pushed a commit that referenced this pull request Jun 22, 2021
* Remove port setting

* Drop one of the params to see what happens

* Split tests into two

* Try using port setting
lexierule pushed a commit that referenced this pull request Jun 22, 2021
* Remove port setting

* Drop one of the params to see what happens

* Split tests into two

* Try using port setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants