Specify packaging version to be more than 17.0 #8030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older version of packaging causes an error when saving model checkpoint. The error is in the atomic_save: `if Version(torch.__version__).release[:3] == (1, 6, 0):` For old version of packaging (e.g., 16.8) the call produce the following errror: `AttributeError: 'Version' object has no attribute 'release'`
GabrielePicco
requested review from
Borda,
SeanNaren,
awaelchli,
carmocca,
justusschock,
kaushikb11,
tchaton and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #8030 +/- ##
=======================================
- Coverage 92% 87% -5%
=======================================
Files 210 210
Lines 13576 13576
=======================================
- Hits 12449 11807 -642
- Misses 1127 1769 +642 |
carmocca
approved these changes
Jun 18, 2021
justusschock
approved these changes
Jun 21, 2021
Borda
approved these changes
Jun 21, 2021
Contributor
Author
|
@awaelchli @Borda @carmocca @justusschock any suggestion of why some tests is failing? |
SkafteNicki
approved these changes
Jun 22, 2021
awaelchli
added a commit
that referenced
this pull request
Jun 29, 2021
awaelchli
added a commit
that referenced
this pull request
Jun 29, 2021
awaelchli
added a commit
that referenced
this pull request
Jun 29, 2021
awaelchli
added a commit
that referenced
this pull request
Jun 30, 2021
awaelchli
pushed a commit
that referenced
this pull request
Jul 1, 2021
lexierule
pushed a commit
that referenced
this pull request
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older version of the
packagingmodule cause an error when saving model checkpoint.The error is in the atomic_save:
if Version(torch.__version__).release[:3] == (1, 6, 0):For old version of packaging (e.g., 16.8) the call produce the following errror:
AttributeError: 'Version' object has no attribute 'release'What does this PR do?
Specify packaging version to be grater or equal to 17.0 in order to avoid bug in the atomic checkpoints save
I tested packing version from 17.0 to 20.9 (latest at the time of writing) and the bug is fixed
How to reproduce the bug
or reproducing the call at line: https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/utilities/cloud_io.py#L61