-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add torchelastic check when sanitizing GPUs #8095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8095 +/- ##
=======================================
- Coverage 92% 87% -5%
=======================================
Files 211 211
Lines 13669 13658 -11
=======================================
- Hits 12538 11895 -643
- Misses 1131 1763 +632 |
awaelchli
approved these changes
Jun 23, 2021
carmocca
approved these changes
Jun 23, 2021
justusschock
approved these changes
Jun 23, 2021
awaelchli
added a commit
that referenced
this pull request
Jun 29, 2021
* Add torchelastic check * Add changelog * Address review * fix
awaelchli
added a commit
that referenced
this pull request
Jun 29, 2021
* Add torchelastic check * Add changelog * Address review * fix
awaelchli
added a commit
that referenced
this pull request
Jun 30, 2021
* Add torchelastic check * Add changelog * Address review * fix
awaelchli
pushed a commit
that referenced
this pull request
Jul 1, 2021
* Add torchelastic check * Add changelog * Address review * fix
lexierule
pushed a commit
that referenced
this pull request
Jul 1, 2021
* Add torchelastic check * Add changelog * Address review * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When using torchelastic, I noticed that
nproc_per_nodeis set to one per gpu device (so if there was 8 GPUs, there are 8 processes) that only see the individual GPU. This means each process sees one GPU at GPU ID 0.This PR skips sanitising the total GPUs when using torchelastic + one visible GPU with multi-gpu setups, assuming torchelastic has created processes.
cc @ananthsub @awaelchli
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃