-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Hotfix Patch Release v1.3.7post0 [full merge, no squash] #8096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.3.x #8096 +/- ##
==============================================
- Coverage 92% 87% -5%
==============================================
Files 200 200
Lines 13067 13067
==============================================
- Hits 12012 11421 -591
- Misses 1055 1646 +591 |
25f5889 to
2d95be8
Compare
2d95be8 to
4c399ca
Compare
ethanwharris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
kaushikb11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
rank_zero_warnandrank_zero_deprecationgot moved out ofutilities.distributed, but this broke back compatibility.PR #8085 fixes this and now we will include it in the bug release branch to unblock flash users.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃