Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 23, 2021

What does this PR do?

rank_zero_warn and rank_zero_deprecation got moved out of utilities.distributed, but this broke back compatibility.
PR #8085 fixes this and now we will include it in the bug release branch to unblock flash users.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added bug Something isn't working priority: 0 High priority task Important and removed bug Something isn't working labels Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #8096 (4c399ca) into release/1.3.x (1a6709d) will decrease coverage by 5%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##           release/1.3.x   #8096    +/-   ##
==============================================
- Coverage             92%     87%    -5%     
==============================================
  Files                200     200            
  Lines              13067   13067            
==============================================
- Hits               12012   11421   -591     
- Misses              1055    1646   +591     

@awaelchli awaelchli added this to the v1.3.x milestone Jun 23, 2021
@awaelchli awaelchli marked this pull request as ready for review June 23, 2021 10:46
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@awaelchli awaelchli changed the title Hotfix Patch Release v1.3.7post [full merge, no squash] Hotfix Patch Release v1.3.7post0 [full merge, no squash] Jun 23, 2021
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@justusschock justusschock enabled auto-merge (squash) June 23, 2021 12:07
@lexierule lexierule disabled auto-merge June 23, 2021 12:50
@lexierule lexierule merged commit 0ba147d into release/1.3.x Jun 23, 2021
@lexierule lexierule deleted the bugfix/1.3.7post branch June 23, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: 0 High priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants