Skip to content

Bugfix/swa iterable dset #8172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 28, 2021
Merged

Bugfix/swa iterable dset #8172

merged 4 commits into from
Jun 28, 2021

Conversation

@justusschock
Copy link
Member

@justusschock justusschock commented Jun 28, 2021

What does this PR do?

Fixes #8150

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@justusschock justusschock self-assigned this Jun 28, 2021
@justusschock justusschock added bug Something isn't working callback labels Jun 28, 2021
@codecov
Copy link

codecov bot commented Jun 28, 2021 •
edited
Loading

Codecov Report

Merging #8172 (ef516bc) into master (c3065c5) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8172    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         211     211            
  Lines       13440   13450    +10     
=======================================
- Hits        12450   11839   -611     
- Misses        990    1611   +621

@justusschock justusschock enabled auto-merge (squash) June 28, 2021 10:22
@justusschock justusschock added the ready PRs ready to be merged label Jun 28, 2021
@justusschock justusschock modified the milestones: v1.3.x, v1.4 Jun 28, 2021
@justusschock justusschock mentioned this pull request Jun 28, 2021
Closed
Borda
Borda approved these changes Jun 28, 2021
View reviewed changes
@justusschock justusschock merged commit d6435a5 into master Jun 28, 2021
@justusschock justusschock deleted the bugfix/swa_iterable_dset branch June 28, 2021 21:18
awaelchli added a commit that referenced this pull request Jun 29, 2021
@awaelchli
Bugfix/swa iterable dset (#8172)
1b36143 
* add test

* add fix

* Update CHANGELOG.md
carmocca
carmocca reviewed Jun 29, 2021
View reviewed changes
pytorch_lightning/callbacks/stochastic_weight_avg.py
trainer.fit_loop._skip_backward = True
self._accumulate_grad_batches = trainer.accumulate_grad_batches
trainer.accumulate_grad_batches = len(trainer.train_dataloader)

Copy link
Contributor

@carmocca carmocca Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justusschock big nit: did you add this newline on purpose? This was a logical block explained by the comment just above

awaelchli added a commit that referenced this pull request Jun 29, 2021
@awaelchli
Bugfix/swa iterable dset (#8172)
410ba15 
* add test

* add fix

* Update CHANGELOG.md
awaelchli added a commit that referenced this pull request Jun 30, 2021
@awaelchli
Bugfix/swa iterable dset (#8172)
d15541f 
* add test

* add fix

* Update CHANGELOG.md
awaelchli pushed a commit that referenced this pull request Jul 1, 2021
@justusschock @awaelchli
Bugfix/swa iterable dset (#8172)
2597781 
* add test

* add fix

* Update CHANGELOG.md
lexierule pushed a commit that referenced this pull request Jul 1, 2021
@justusschock @lexierule
Bugfix/swa iterable dset (#8172)
a6beac9 
* add test

* add fix

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+3 more reviewers

@carmocca carmocca carmocca left review comments

@awaelchli awaelchli awaelchli approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@justusschock justusschock

Labels

bug Something isn't working callback ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.3.x

Development

Successfully merging this pull request may close these issues.

SWA error with Iterable Dataset and DDP after the last epoch

5 participants

@justusschock @awaelchli @Borda @carmocca @kaushikb11