-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Raise exception for ddp_cpu not supported for TPUs #8530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise exception for ddp_cpu not supported for TPUs #8530
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8530 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 218 218
Lines 14404 14406 +2
=======================================
- Hits 13297 12703 -594
- Misses 1107 1703 +596 |
|
@kaushikb11 still draft? |
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks for checking that
|
Hello @kaushikb11! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-26 10:06:24 UTC |
Co-authored-by: thomas chaton <thomas@grid.ai>
6ba4d22 to
01ab21f
Compare
for more information, see https://pre-commit.ci
What does this PR do?
Fixes #7810
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃