Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jul 26, 2021

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes ? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #8553 (eb2768b) into master (c5167e9) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8553    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         218     218            
  Lines       14403   14403            
=======================================
- Hits        13299   12704   -595     
- Misses       1104    1699   +595     

@mergify mergify bot added the ready PRs ready to be merged label Jul 26, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Borda and others added 3 commits July 26, 2021 15:30
@lexierule lexierule disabled auto-merge July 26, 2021 14:01
@lexierule lexierule merged commit 75e18a5 into master Jul 26, 2021
@lexierule lexierule deleted the vrc2 branch July 26, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants