Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Aug 10, 2021

What does this PR do?

in TM the mean_relative_error was deprecated

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working ci Continuous Integration priority: 1 Medium priority task labels Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #8830 (372ca01) into master (3ef8cd6) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8830    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         169     169            
  Lines       14072   14072            
=======================================
- Hits        13044   12466   -578     
- Misses       1028    1606   +578     

@mergify mergify bot added the ready PRs ready to be merged label Aug 10, 2021
@tchaton tchaton enabled auto-merge (squash) August 10, 2021 09:04
@Borda Borda added this to the v1.4.x milestone Aug 10, 2021
@tchaton tchaton merged commit 3096ab8 into master Aug 10, 2021
@tchaton tchaton deleted the tests/fix-tm-mape branch August 10, 2021 09:26
SeanNaren pushed a commit that referenced this pull request Aug 10, 2021
(cherry picked from commit 3096ab8)
lexierule pushed a commit that referenced this pull request Aug 11, 2021
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants