Skip to content

Conversation

@ethanwharris
Copy link
Member

What does this PR do?

Sphinx build CI is breaking and couldn't find a fix. Not needed anyway as docs build is covered by the other CI and pre-commit

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #8934 (4ac5edf) into master (d0efb55) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8934    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         172     172            
  Lines       14093   14093            
=======================================
- Hits        13095   12516   -579     
- Misses        998    1577   +579     

@mergify mergify bot added the ready PRs ready to be merged label Aug 16, 2021
@justusschock justusschock enabled auto-merge (squash) August 16, 2021 15:20
@awaelchli awaelchli added docs Documentation related ci Continuous Integration labels Aug 16, 2021
@awaelchli
Copy link
Contributor

adding 1.4.x label so we don't forget to include it in the bugfix branch too :)

@awaelchli awaelchli added this to the v1.4.x milestone Aug 16, 2021
@justusschock justusschock merged commit 92333c2 into master Aug 16, 2021
@justusschock justusschock deleted the bugfix/drop_sphinx_ci branch August 16, 2021 17:51
@daniellepintz
Copy link
Contributor

this is awesome! next, can we either fix or delete the TPU tests to get closer to a green CI? cc @Borda

awaelchli pushed a commit that referenced this pull request Aug 17, 2021
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Aug 18, 2021
lexierule pushed a commit that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants