-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Drop breaking sphinx docs build #8934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8934 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 172 172
Lines 14093 14093
=======================================
- Hits 13095 12516 -579
- Misses 998 1577 +579 |
SeanNaren
approved these changes
Aug 16, 2021
kaushikb11
approved these changes
Aug 16, 2021
justusschock
approved these changes
Aug 16, 2021
awaelchli
approved these changes
Aug 16, 2021
Contributor
|
adding 1.4.x label so we don't forget to include it in the bugfix branch too :) |
Borda
approved these changes
Aug 16, 2021
Contributor
|
this is awesome! next, can we either fix or delete the TPU tests to get closer to a green CI? cc @Borda |
awaelchli
pushed a commit
that referenced
this pull request
Aug 17, 2021
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
Aug 18, 2021
lexierule
pushed a commit
that referenced
this pull request
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sphinx build CI is breaking and couldn't find a fix. Not needed anyway as docs build is covered by the other CI and pre-commit
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃