Skip to content

Conversation

@awaelchli
Copy link
Contributor

What does this PR do?

Addresses comments missed in #8889 by reviewer.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the docs Documentation related label Aug 17, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #8952 (0736ef5) into master (413f7b2) will decrease coverage by 4%.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #8952    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         176     176            
  Lines       14411   14411            
=======================================
- Hits        13352   12772   -580     
- Misses       1059    1639   +580     

@awaelchli awaelchli marked this pull request as ready for review August 17, 2021 12:58
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) August 17, 2021 17:16
@mergify mergify bot added the ready PRs ready to be merged label Aug 17, 2021
@tchaton tchaton merged commit 38ceb89 into master Aug 18, 2021
@tchaton tchaton deleted the docs/cycle-iterator branch August 18, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants