-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix batch auto scaling when init_val causes OOM
#8954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8954 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 176 176
Lines 14270 14271 +1
=======================================
- Hits 13260 12681 -579
- Misses 1010 1590 +580 |
awaelchli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix.
this is caused when we get OOM at the first trainer run, correct?
Correct! |
|
@eladsegal could you go through the checklist on the PR description and add a changelog entry too? |
for more information, see https://pre-commit.ci
|
Sure, done @awaelchli |
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
* fix batch auto scaling when `init_val` causes OOM * Update CHANGELOG.md Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix batch auto scaling when `init_val` causes OOM * Update CHANGELOG.md Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
What does this PR do?
When
init_valbatch size causes OOM,lowvariable is never set but is still required in the exception handling.This pull request gives
lowa default value of 1 which will be overwritten ifinit_valdoesn't cause OOM.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃