Skip to content

Conversation

@eladsegal
Copy link
Contributor

@eladsegal eladsegal commented Aug 17, 2021

What does this PR do?

When init_val batch size causes OOM, low variable is never set but is still required in the exception handling.
This pull request gives low a default value of 1 which will be overwritten if init_val doesn't cause OOM.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #8954 (54ae6dc) into master (de22e40) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8954    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         176     176            
  Lines       14270   14271     +1     
=======================================
- Hits        13260   12681   -579     
- Misses       1010    1590   +580     

@awaelchli awaelchli added the bug Something isn't working label Aug 17, 2021
@awaelchli awaelchli added this to the v1.4.x milestone Aug 17, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix.
this is caused when we get OOM at the first trainer run, correct?

@eladsegal
Copy link
Contributor Author

thanks for the fix.
this is caused when we get OOM at the first trainer run, correct?

Correct!

@awaelchli
Copy link
Contributor

@eladsegal could you go through the checklist on the PR description and add a changelog entry too?
I believe we can omit the test due to its complexity and dependence on the particular system and load.

@eladsegal
Copy link
Contributor Author

Sure, done @awaelchli

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot added the ready PRs ready to be merged label Aug 17, 2021
@SkafteNicki SkafteNicki merged commit 413f7b2 into Lightning-AI:master Aug 18, 2021
@eladsegal eladsegal deleted the patch-2 branch August 18, 2021 07:57
awaelchli pushed a commit that referenced this pull request Aug 24, 2021
* fix batch auto scaling when `init_val` causes OOM

* Update CHANGELOG.md

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
lexierule pushed a commit that referenced this pull request Aug 24, 2021
* fix batch auto scaling when `init_val` causes OOM

* Update CHANGELOG.md

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged tuner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants