Skip to content

Conversation

@guotuofeng
Copy link
Contributor

@guotuofeng guotuofeng commented Sep 13, 2021

What does this PR do?

Add @guotuofeng @nbcsm as the code owner for the PyTorch Profiler within Lightning.

Note for reviewer: They maintain the Kineto PyTorch Profiler.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for adding yourselves :)

@mergify mergify bot added the ready PRs ready to be merged label Sep 13, 2021
@mergify mergify bot requested a review from a team September 13, 2021 08:35
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #9479 (322fe7f) into master (f949a22) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9479    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         180     180            
  Lines       15064   15064            
=======================================
- Hits        13984   13371   -613     
- Misses       1080    1693   +613     

@awaelchli awaelchli added the admin Requires admin privileges to merge label Sep 13, 2021
@tchaton tchaton enabled auto-merge (squash) September 13, 2021 10:57
@carmocca carmocca added this to the v1.4.x milestone Sep 13, 2021
@lexierule lexierule disabled auto-merge September 13, 2021 13:19
@lexierule lexierule merged commit 07e94b8 into Lightning-AI:master Sep 13, 2021
@guotuofeng guotuofeng deleted the myguo/owner branch September 14, 2021 00:11
ethanwharris pushed a commit that referenced this pull request Sep 14, 2021
lexierule pushed a commit that referenced this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

admin Requires admin privileges to merge ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants