Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Apr 14, 2022

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

for generating bash script define the output file so eventual errors are not hidden in the generated scripts

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #157 (6024db4) into main (c257c46) will decrease coverage by 0%.
The diff coverage is 83%.

@@         Coverage Diff         @@
##           main   #157   +/-   ##
===================================
- Coverage    75%    75%   -0%     
===================================
  Files         2      2           
  Lines       355    363    +8     
===================================
+ Hits        267    273    +6     
- Misses       88     90    +2     

@Borda Borda enabled auto-merge (squash) April 14, 2022 08:08
@Borda Borda merged commit dccda32 into main Apr 14, 2022
@Borda Borda deleted the ci/outputs branch April 14, 2022 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants