Skip to content

chore: support more proxy http method #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

chore: support more proxy http method #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions cmd/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,8 @@ func (o *serverOption) runE(cmd *cobra.Command, args []string) (err error) {
mux.HandlePath(http.MethodGet, "/favicon.ico", frontEndHandlerWithLocation(o.consolePath))
mux.HandlePath(http.MethodGet, "/swagger.json", frontEndHandlerWithLocation(o.consolePath))
mux.HandlePath(http.MethodGet, "/data/{data}", o.dataFromExtension(remoteServer.(server.UIExtensionServer)))
mux.HandlePath(http.MethodPost, "/extensionProxy/{extension}", func(w http.ResponseWriter, r *http.Request, pathParams map[string]string) {

proxyHandler := func(w http.ResponseWriter, r *http.Request, pathParams map[string]string) {
extServer := remoteServer.(server.UIExtensionServer)

ctx := r.Context()
Expand All @@ -388,8 +389,8 @@ func (o *serverOption) runE(cmd *cobra.Command, args []string) (err error) {
return
}

fmt.Println("redirect to", resp.Message)
req, err := http.NewRequestWithContext(ctx, http.MethodPost, resp.Message, r.Body)
fmt.Println("redirect to", resp.Message, "method", r.Method)
req, err := http.NewRequestWithContext(ctx, r.Method, resp.Message, r.Body)
if err != nil {
fmt.Println(err)
return
Expand All @@ -416,14 +417,19 @@ func (o *serverOption) runE(cmd *cobra.Command, args []string) (err error) {
var count int
for {
count, err = rsp.Body.Read(data)
if count == -1 || count == 0 || err != nil {
if count == -1 || count == 0 || (err != nil && count <= 0) {
fmt.Println("failed to read response body", err)
w.WriteHeader(http.StatusInternalServerError)
flusher.Flush()
break
}
w.Write(data[:count])
flusher.Flush()
}
})
}
mux.HandlePath(http.MethodPost, "/extensionProxy/{extension}", proxyHandler)
mux.HandlePath(http.MethodGet, "/extensionProxy/{extension}", proxyHandler)
mux.HandlePath(http.MethodDelete, "/extensionProxy/{extension}", proxyHandler)
mux.HandlePath(http.MethodGet, "/get", o.getAtestBinary)
mux.HandlePath(http.MethodPost, "/runner/{suite}/{case}", service.WebRunnerHandler)
mux.HandlePath(http.MethodGet, "/api/v1/sbom", service.SBomHandler)
Expand Down
8 changes: 4 additions & 4 deletions console/atest-ui/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ export default defineConfig(({mode}) => {
target: env.VITE_API_URL,
changeOrigin: true,
},
'/extensionProxy': {
target: 'http://127.0.0.1:8080',
changeOrigin: true,
},
'/extensionProxy': {
target: env.VITE_API_URL,
changeOrigin: true,
},
'/data': {
target: env.VITE_API_URL,
changeOrigin: true,
Expand Down
Loading