Skip to content

Conversation

@teriyakisushi
Copy link
Contributor

Fix for Issue #525

Deprecation Notices Addressed

  1. Replaced deprecated --rm-dist flag with the recommended --clean flag in release.yaml , as per GoReleaser deprecation notice
- args: release --rm-dist
+ args: release --clean
  1. Updated GitHub Actions workflow to use ubuntu-latest instead of the deprecated ubuntu-20.04 image, which has been removed by GitHub
- runs-on: ubuntu-20.04
+ runs-on: ubuntu-latest

Format Standardization

  1. Updated .goreleaser configuration to use the latest version: 2 format
+ version: 2
  1. Fixed several deprecated configurations identified during dry run testing:

    • snapshot.name_template
    • archives.builds
    • archives.format_overrides.format

    Full details available in this job log

Testing Results

  • Verified changes locally using the act tool to simulate GitHub Actions (excluding jobs requiring authentication)

act_test_result

  • Successfully tested on my fork at with GitHub Actions running properly, See this job details.

Questions

  1. Would you prefer to accept these updated format standards, or would you prefer to maintain consistency with other plugins by keeping the original format?

  2. Regarding GitHub Actions runner: I've used ubuntu-latest to replace the deprecated ubuntu-20.04. Would you prefer I specifically use ubuntu-22.04 instead of ubuntu-latest?

@LinuxSuRen LinuxSuRen added the bug Something isn't working label Apr 28, 2025
Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @teriyakisushi thanks for your time. I appreciate the detailed information you've provided. It's great and helpful.

close LinuxSuRen/api-testing#525

@LinuxSuRen LinuxSuRen merged commit 1a65570 into LinuxSuRen:master Apr 28, 2025
3 checks passed
@teriyakisushi
Copy link
Contributor Author

hi @teriyakisushi thanks for your time. I appreciate the detailed information you've provided. It's great and helpful.

close LinuxSuRen/api-testing#525

Thank you for merging my PR and for your feedback! I learned a lot through this process 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants