Skip to content
This repository was archived by the owner on Jun 11, 2024. It is now read-only.

Add check for address and BLS key uniquess of validators in LIP 0058#295

Merged
janhack merged 4 commits into
mainfrom
jan_address-bls-key-uniqueness
Mar 6, 2023
Merged

Add check for address and BLS key uniquess of validators in LIP 0058#295
janhack merged 4 commits into
mainfrom
jan_address-bls-key-uniqueness

Conversation

@janhack
Copy link
Copy Markdown
Contributor

@janhack janhack commented Mar 3, 2023 •
edited
Loading

This PR add the following checks to the function setBFTParameters in LIP 0058:

  • Check that addresses of provided validators are unique.
  • Check that BLS keys of provided validators are unique.

Resolves #279

@janhack janhack self-assigned this Mar 3, 2023
@janhack janhack requested review from AndreasKendziorra, ricott1 and shuse2 and removed request for ricott1 March 3, 2023 12:46
@shuse2 shuse2 mentioned this pull request Mar 3, 2023
Closed
shuse2
shuse2 approved these changes Mar 3, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in SDK LiskArchive/lisk-sdk#8222

@shuse2 shuse2 mentioned this pull request Mar 3, 2023
Open
AndreasKendziorra
AndreasKendziorra suggested changes Mar 3, 2023
View reviewed changes
Comment thread proposals/lip-0058.md Outdated
@janhack janhack changed the title Add check for address and key uniquess of validators in LIP 0058 Add check for address and BLS key uniquess of validators in LIP 0058 Mar 3, 2023
@janhack janhack requested a review from shuse2 March 3, 2023 14:51
@janhack janhack requested review from AnanyaSshri and ricott1 and removed request for ricott1 March 3, 2023 15:53
@janhack janhack merged commit 9f86d43 into main Mar 6, 2023
@janhack janhack deleted the jan_address-bls-key-uniqueness branch March 6, 2023 17:39
@janhack janhack mentioned this pull request Mar 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@shuse2 shuse2 shuse2 approved these changes

@AndreasKendziorra AndreasKendziorra AndreasKendziorra approved these changes

@AnanyaSshri AnanyaSshri AnanyaSshri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@janhack janhack

Labels

implementation change lip modification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing check for address and BLS key uniqueness

4 participants

@janhack @shuse2 @AndreasKendziorra @AnanyaSshri