Skip to content
This repository was archived by the owner on Jun 11, 2024. It is now read-only.

Rollback version patching mechanism - Closes #2466#2467

Merged
MaciejBaj merged 12 commits into
1.1.0from
2466-version_patching_rollback
Oct 15, 2018
Merged

Rollback version patching mechanism - Closes #2466#2467
MaciejBaj merged 12 commits into
1.1.0from
2466-version_patching_rollback

Conversation

@jondubois
Copy link
Copy Markdown
Contributor

@jondubois jondubois commented Oct 12, 2018

What was the problem?

Our approach to versioning should be compatible with older nodes.
A previous incomplete patch needed to be rolled back. We need to change our approach to versioning to be compatible with testnet nodes.

How did I fix it?

How to test it?

Run the node and connect to testnet, peer disconnects with code 1000 should not (or rarely) happen during the sync phase.

Review checklist

@MaciejBaj MaciejBaj merged commit 842a491 into 1.1.0 Oct 15, 2018
@MaciejBaj MaciejBaj deleted the 2466-version_patching_rollback branch October 15, 2018 07:47
@webmaster128
Copy link
Copy Markdown
Contributor

webmaster128 commented Oct 15, 2018

After this change, 1.1.0-rc.0 can still not connect to 1.0.0-rc.4 and 1.0.0-rc.5 nodes. I needed to revert be4d8fd in order to get current 1.1.0 branch synchonizing.

By the way: why minVersion bump again? This is the next hard fork

@jondubois
Copy link
Copy Markdown
Contributor Author

jondubois commented Oct 16, 2018

@webmaster128 That's correct. This PR reverts a patch which did not work as intended. There were two options; push forward with the hack (making more changes to the code) until everything appears to work, or roll back what we had and find an alternative solution.

Since this issue only affects testnet, it was decided that the best solution for it did not require a code change. There should be an announcement very soon about next steps for testnet 1.1.

@webmaster128
Copy link
Copy Markdown
Contributor

@jondubois thanks for the info. I am happy this is expeted behaviour and well known. Looking forward to see 1.1 being deployed.

@MaciejBaj
Copy link
Copy Markdown
Contributor

MaciejBaj commented Oct 16, 2018

@webmaster128 I summarized the steps here #2389 (comment).

@MaciejBaj MaciejBaj restored the 2466-version_patching_rollback branch October 16, 2018 14:35
@shuse2 shuse2 deleted the 2466-version_patching_rollback branch April 3, 2019 06:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants