Rollback version patching mechanism - Closes #2466#2467
Conversation
This reverts commit 7cf6f2e.
This reverts commit 7809eee.
…Release" This reverts commit 55f499f.
This reverts commit 483fa0b.
This reverts commit 7f59ab1.
This reverts commit e450733.
This reverts commit 98eeece.
This reverts commit ae63171.
This reverts commit 072580c.
This reverts commit c9f14ef.
… releases" This reverts commit 470e737.
…le times to the same array
|
After this change, 1.1.0-rc.0 can still not connect to 1.0.0-rc.4 and 1.0.0-rc.5 nodes. I needed to revert be4d8fd in order to get current 1.1.0 branch synchonizing. By the way: why minVersion bump again? This is the next hard fork |
|
@webmaster128 That's correct. This PR reverts a patch which did not work as intended. There were two options; push forward with the hack (making more changes to the code) until everything appears to work, or roll back what we had and find an alternative solution. Since this issue only affects testnet, it was decided that the best solution for it did not require a code change. There should be an announcement very soon about next steps for testnet 1.1. |
|
@jondubois thanks for the info. I am happy this is expeted behaviour and well known. Looking forward to see 1.1 being deployed. |
|
@webmaster128 I summarized the steps here #2389 (comment). |
What was the problem?
Our approach to versioning should be compatible with older nodes.
A previous incomplete patch needed to be rolled back. We need to change our approach to versioning to be compatible with testnet nodes.
How did I fix it?
1.1.0How to test it?
Run the node and connect to testnet, peer disconnects with
code 1000should not (or rarely) happen during the sync phase.Review checklist