Control Center: Add missing Options, and Fix some

[iamanaws]

No description provided.

[iamanaws]

I just have doubt about the options that change their type, I know there are ways, but here I'm not sure how to add a warning or heads up, to indicate the allowed values had changed

[bew]

A few comments on the options ;)

For the type change, we could have backward compatibility with warning by adding true & false in the mkXXXXApply mapping functions like:

mkEnumApply {
  always = 21,
  hide = 42,
  true = lib.warn ''something something use "always" now'' 21,
  false = lib.warn ''something something use `"hide"` now'' 42,
}

[bew]

Thanks for the changes, looks nice!

While looking at the test file I noticed something that might be improved:

  system.defaults.controlcenter.Sound = "always";
  system.defaults.controlcenter.StageManager = true;
  system.defaults.controlcenter.UserSwitcher = "menuBar";
  system.defaults.controlcenter.WiFi = true;

Those lines show how inconsistent the values are for seemingly similar options: some are true, others are "always" or "menuBar"..
👉 Could we avoid having multiple values for the same thing? 🤔

[iamanaws]

Thanks for the changes, looks nice!

While looking at the test file I noticed something that might be improved:

  system.defaults.controlcenter.Sound = "always";
  system.defaults.controlcenter.StageManager = true;
  system.defaults.controlcenter.UserSwitcher = "menuBar";
  system.defaults.controlcenter.WiFi = true;

I updated the test file to use the same values for options that share the same type.
So now we only apply "both", "always", and true.

Is that what you meant?

Those lines show how inconsistent the values are for seemingly similar options: some are true, others are "always" or "menuBar".. 👉 Could we avoid having multiple values for the same thing? 🤔

I leave as bool the ones that are more simple, but I could change them to reflect better the options. I grouped similar stuff and leave just 3 different patterns.

[iamanaws]

It's been a few months, but I cleaned it up!