Skip to content

Inline updateRecordVisibility function #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2021
Merged

Inline updateRecordVisibility function #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions src/Tree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ const generateNewTree = <
// extremely complex but the first build is quite easy. During the following
// idle callbacks the old tree will be shown.
!(placeholder === null && !state.order);

const hasTime = useIdleCallback
? (deadline: RequestIdleCallbackDeadline) => deadline.timeRemaining() > 0
: () => true;
Expand Down Expand Up @@ -384,16 +385,6 @@ const generateNewTree = <
: {order, records};
};

const updateRecordVisibility = <
TData extends NodeData,
TNodePublicState extends NodePublicState<TData>
>(
record: NodeRecord<TNodePublicState>,
): void => {
const {parent} = record;
record.isShown = parent ? parent.public.isOpen && parent.isShown : true;
};

const MAX_FUNCTION_ARGUMENTS = 32768;

// If we need to perform only the update, treeWalker won't be used. Update will
Expand Down Expand Up @@ -480,7 +471,11 @@ const updateExistingTree = <
// the order list yet. We should do it AFTER the visibility update
// happens because otherwise we won't be able to distinguish if the
// element should be included in the order list.
updateRecordVisibility(record);

// Update record visibility
record.isShown = record.parent
? record.parent.public.isOpen && record.parent.isShown
: true;

if (record.isShown) {
orderParts[orderPartsCursor].push(record.public.data.id);
Expand Down Expand Up @@ -523,7 +518,10 @@ const updateExistingTree = <
count += 1;
}

updateRecordVisibility(record);
// Update record visibility
record.isShown = record.parent
? record.parent.public.isOpen && record.parent.isShown
: true;
};

apply = () => {
Expand Down