Skip to content

Conversation

@lukasbuenger
Copy link
Contributor

@lukasbuenger lukasbuenger commented Mar 31, 2021

From v7 onwards, NPM tries to automatically install peer dependencies and will throw, if any packages in the dependency tree have conflicting versions of the same peer dependency [1]. Therefore I suggest to impose soft peer dependency requirements:

  • react and react-dom greater than 16.8 (the version which introduced hooks)
  • react-window greater than 1.8.5 (the version this lib is tested against).

I'd also remove the peer dependency on the typings, as that might throw off non-Typescript users.

[1] https://github.blog/2020-10-13-presenting-v7-0-0-of-the-npm-cli/

@Lodin
Copy link
Owner

Lodin commented Apr 30, 2021

Hmm, what about making the typings optional then?

@lukasbuenger
Copy link
Contributor Author

lukasbuenger commented May 12, 2021

Hmm, what about making the typings optional then?

Optional would work, sure. But even then I'd go with a minimal required version rather than a specific one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants