Make peer dependencies more lenient. #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From v7 onwards, NPM tries to automatically install peer dependencies and will throw, if any packages in the dependency tree have conflicting versions of the same peer dependency [1]. Therefore I suggest to impose soft peer dependency requirements:
reactandreact-domgreater than16.8(the version which introduced hooks)react-windowgreater than1.8.5(the version this lib is tested against).I'd also remove the peer dependency on the typings, as that might throw off non-Typescript users.
[1] https://github.blog/2020-10-13-presenting-v7-0-0-of-the-npm-cli/