Info API: OrderFill fields #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
hyperliquidpackage, focusing on improving error handling, enhancing test coverage, and updating data types for consistency. The most important changes include adding error checks, improving test logging, and converting string fields to float64 in theOrderFillstruct.Error handling improvements:
hyperliquid/info_test.go: Added a check to ensureTEST_ADDRESSis set in the environment, and panic if it is not.Test coverage enhancements:
hyperliquid/info_test.go: Enhanced theTestInfoAPI_GetAccountFillsfunction by adding detailed logging and additional checks forPx,Sz, andFeefields in the response.Data type consistency:
hyperliquid/info_types.go: Updated theOrderFillstruct to convertClosedPnl,Fee,Px, andSzfields from strings to float64 for better numerical handling.