Skip to content

Conversation

@0xBoringWozniak
Copy link
Member

@0xBoringWozniak 0xBoringWozniak commented Jul 10, 2024

This pull request includes several changes to the hyperliquid package, focusing on improving error handling, enhancing test coverage, and updating data types for consistency. The most important changes include adding error checks, improving test logging, and converting string fields to float64 in the OrderFill struct.

Error handling improvements:

Test coverage enhancements:

  • hyperliquid/info_test.go: Enhanced the TestInfoAPI_GetAccountFills function by adding detailed logging and additional checks for Px, Sz, and Fee fields in the response.

Data type consistency:

  • hyperliquid/info_types.go: Updated the OrderFill struct to convert ClosedPnl, Fee, Px, and Sz fields from strings to float64 for better numerical handling.

@0xBoringWozniak 0xBoringWozniak added enhancement New feature or request info /info endpoint labels Jul 10, 2024
@0xBoringWozniak 0xBoringWozniak self-assigned this Jul 10, 2024
@0xBoringWozniak 0xBoringWozniak merged commit ecb9bf9 into main Jul 10, 2024
@0xBoringWozniak 0xBoringWozniak deleted the fix-user-fills-types branch July 10, 2024 13:02
@0xBoringWozniak 0xBoringWozniak changed the title Update Info::OrderFill fields Info API: OrderFill fields Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request info /info endpoint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants