Skip to content

Conversation

@zzznz27
Copy link
Contributor

@zzznz27 zzznz27 commented Sep 16, 2024

Added the functionality to choose which Managed APIs should be mocked.

To add a mock api, specify its connection name in the managedApisToMock property in the test properties:

{
    "logging": {
        "writeFunctionRuntimeStartupLogs": true,
        "WriteMockRequestMatchingLogs": true
    },
    "workflow": {
        "externalApiUrlsToMock": [],
        "builtInConnectorsToMock": [],
        "managedApisToMock": [
            "outlook"
        ]
    }
}

@mark-abrams
Copy link
Collaborator

Hi @zzznz27 , thank you for the PR, a good improvement. One comment though. Any changes must ensure backwards compatibility with previous versions so that existing tests are not broken. Therefore a config file without the new setting to filter managed connectors must mock all managed API connectors. Does your change do this?

@zzznz27
Copy link
Contributor Author

zzznz27 commented Sep 18, 2024

It currently does not but I'll will make some changes to ensure existing functionality is maintained

Thnks for the suggestion!

@zzznz27
Copy link
Contributor Author

zzznz27 commented Sep 18, 2024

Changed have been made to ensure backwards compatibility

@LogicAppUnit LogicAppUnit merged commit fac21e3 into LogicAppUnit:main Sep 25, 2024
@LogicAppUnit
Copy link
Owner

Hi @zzznz27 , I have approved and completed the PR. I need to work through the other two outstanding PRs, then I'll publish a new version to NuGet. Thanks for your contribution and sorry about the delay in sorting this out.

@mark-abrams
Copy link
Collaborator

Hi @zzznz27 , I have released version 1.10.0 of LogicAppUnit. Thank you for your contribution, and many apologies for the delay in shipping the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants