Skip to content

Conversation

@schas002
Copy link

@schas002 schas002 commented Sep 9, 2016

No description provided.

@bortkiewicz
Copy link
Collaborator

Do we need this???

@somebody1234
Copy link
Contributor

@schas002 I'll merge it after you remove redundant lines

@schas002
Copy link
Author

Which lines are redundant?

@bortkiewicz
Copy link
Collaborator

Comments?

@schas002
Copy link
Author

Yeah, comments.

@bortkiewicz
Copy link
Collaborator

What is this to do anyways???

@somebody1234
Copy link
Contributor

@schas002 Also the empty lines like <Keywords name="Numbers, prefix1"></Keywords> look like they
're redundant too

@schas002
Copy link
Author

⬆️ but idk could it work w/o these lines.

@somebody1234
Copy link
Contributor

@schas002 Can't you just test it to see if it works?

@schas002
Copy link
Author

Okay, I'll test it.

@hanyuone
Copy link
Collaborator

@schas002 Is the testing done?

@schas002
Copy link
Author

Not yet.

@schas002
Copy link
Author

In fact, I didn't even do the testing. 😦

@bortkiewicz
Copy link
Collaborator

Is this PR abandoned?

@bortkiewicz
Copy link
Collaborator

bortkiewicz commented Oct 4, 2016

IS THIS PULL REQUEST ABANDONED?

@schas002 schas002 closed this Oct 4, 2016
@schas002
Copy link
Author

schas002 commented Oct 4, 2016

Now it is. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants