Fix Windows 8.3 file name handling#206
Merged
mherger merged 1 commit intoLMS-Community:public/7.9from Jun 15, 2018
Merged
Conversation
Contributor
|
Could you provide a sample file, or a filename I can use to test this with? |
Contributor
Author
|
I attached the file with zip that is containing one mp3 file for testing. [Incorrect encoding (garbled)] |
Contributor
|
That file didn't even arrive on my computer:
Could you please upload the raw file (not compressed) to the following link: https://www.dropbox.com/request/5nM0UBKfwnghGkyAZy9F Thanks! |
Contributor
|
Let's give this a try anyway. Shouldn't hurt. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filename who has multi-byte characters that contain 0x7e is garbled.
(ex. {0x83, 0x7e} expresses "ミ" in Shift-JIS, and this regular expression will catch the character.)
This change fixes the issue that showing garbled file name in "Browse Music Folder".