Update maths.py #229
Merged
Update maths.py #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lachlangrose
left a comment
lachlangrose
left a comment
There was a problem hiding this comment.
Thanks Axel, did you mean to change the order of plunge and plunge direction?
| def azimuthplunge2vector( | ||
| plunge: NumericInput, | ||
| plunge_dir: NumericInput, | ||
| plunge: NumericInput, |
Member
There was a problem hiding this comment.
Did you mean to change the order of the variables?
Contributor
Author
There was a problem hiding this comment.
Yes, I meant to make them coherent with the name of the function. I have no idea if that would change anything with the actual code though. Do you know if there is a way to access every single call to that function in the whole project?
Member
There was a problem hiding this comment.
@AxMeNi, I think I would rather keep it as plunge and plunge_dir because that is the order we refer to them as geologists. But maybe we should change the function name, but we need to add a deprecation to the old naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor documentation updates for maths.py (my first contribution to LoopStructural :) )