Skip to content

Fix. easy:reset() returns correct value #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Fix. easy:reset() returns correct value #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/cURLv3/uvwget.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ local curl_check_multi_info = function()

if ok then on_end(easy, nil, done_url) else on_end(easy, err, done_url) end

easy:reset().data = nil
easy:reset()
easy.data = nil
qfree:push(easy)
end

Expand Down
1 change: 1 addition & 0 deletions src/lceasy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ static int lcurl_easy_reset(lua_State *L){
if(p->storage != LUA_NOREF){
lcurl_storage_free(L, p->storage);
p->storage = lcurl_storage_init(L);
lua_settop(L, 1);
}

return 1;
Expand Down
4 changes: 2 additions & 2 deletions test/test_easy.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,7 +885,7 @@ function test_unset()
gc_collect()
assert(pfrom.value)

e:unsetopt_httppost()
assert_equal(e, e:unsetopt_httppost())

gc_collect()
assert(not pfrom.value)
Expand All @@ -902,7 +902,7 @@ function test_reset()
gc_collect()
assert(pfrom.value)

e:reset()
assert_equal(e, e:reset())

gc_collect()
assert(not pfrom.value)
Expand Down