Script bug fix #30
Merged
Script bug fix #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug with the client’s script method. The script method was parsing all values as json. The script method now only attempts to parse valid json. Signed-off-by: Lui de la Parra <lui@mutesymphony.com>
This commit updates the isJson utility function to better identify null, strings, undefined, or a number. This commit also adds tests specific to the isJson utility. Signed-off-by: Lui de la Parra <lui@mutesymphony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bug fix addressing the client script method. The script method would incorrectly parse script parameter strings as json. This PR upgrades the isJson utility method to correctly identify json objects.