docs: fix README TypeScript example for Microsoft.getAuth #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luuxis
force-pushed
the
master
branch
3 times, most recently
from
03b7c03 to
41a1b4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update straightens out the “Standard Example (ESM)” snippet so newcomers can copy-paste it and launch the game without surprises.
What changed
client_idto the constructor –new Microsoft('<client_id>').getAuth('terminal')(or'electron' | 'nwjs') instead of feeding it an object it can’t parse.Why
The previous sample looked fine at a glance but silently returned
false, causing the launcher to run offline (or just error). This tweak matches the actual method signature and works out-of-the-box on Node 18+ / TS 5.No library code changes, just docs.