Skip to content

Add fullscreen support to album and photo views#146

Merged
ildyria merged 2 commits intomasterfrom
fullscreen
Mar 19, 2019
Merged

Add fullscreen support to album and photo views#146
ildyria merged 2 commits intomasterfrom
fullscreen

Conversation

@kamil4
Copy link
Contributor

@kamil4 kamil4 commented Mar 17, 2019

Finally takes care of my pet project #94

Front end part is at LycheeOrg/Lychee-front#52

Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we are using the blade template, this will break for any non-English language.

Please add the 2 lines into the other languages (even if not translated) in order to avoid a key not defined when trying to get $locale['FULLSCREEN_EXIT']

@kamil4
Copy link
Contributor Author

kamil4 commented Mar 17, 2019

My latest commit should address this. @d7415 do I need to do the same with #228? I added the locale strings there but then I realized that index.html isn't localized...

@d7415
Copy link
Contributor

d7415 commented Mar 17, 2019

My latest commit should address this. @d7415 do I need to do the same with LycheeOrg/Lychee#228? I added the locale strings there but then I realized that index.html isn't localized...

I think it's fine. I don't think Lychee does any localisation itself, only the front-end.

Lychee-front does update some of index.html (the star one in particular I've noticed when playing) but that's out of scope (and I think falls back to the values in lychee_locale.js anyway)

@ildyria ildyria merged commit 9cd4be3 into master Mar 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the fullscreen branch March 19, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants