Add fullscreen support to album and photo views#146
Merged
Conversation
ildyria
requested changes
Mar 17, 2019
Member
ildyria
left a comment
There was a problem hiding this comment.
Because we are using the blade template, this will break for any non-English language.
Please add the 2 lines into the other languages (even if not translated) in order to avoid a key not defined when trying to get $locale['FULLSCREEN_EXIT']
Contributor
Author
Contributor
I think it's fine. I don't think Lychee does any localisation itself, only the front-end. Lychee-front does update some of index.html (the star one in particular I've noticed when playing) but that's out of scope (and I think falls back to the values in |
ildyria
approved these changes
Mar 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally takes care of my pet project #94
Front end part is at LycheeOrg/Lychee-front#52