Skip to content

Conversation

@yorkie
Copy link
Member

@yorkie yorkie commented Aug 18, 2025

This pull request removes support for Babylon.js-specific bootstrap code and related framework selection logic from both the build system and runtime APIs, simplifying the codebase and focusing the runtime on more general document loading and viewing. It also cleans up unused or redundant files and interfaces, and refactors the document loading logic to streamline the handling of various content types.

@yorkie yorkie requested a review from Copilot August 18, 2025 09:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes Babylon.js-specific dependencies and JSARDOM framework code to reduce package size and simplify the codebase. The changes focus the runtime on more general document loading capabilities while removing specialized 3D rendering framework support.

Key changes:

  • Removed Babylon.js package dependency and bootstrap scripts from build system
  • Simplified document loading to use standard HTML instead of specialized XSML format
  • Cleaned up WebXR motion controller implementations that were Babylon.js-specific

Reviewed Changes

Copilot reviewed 47 out of 50 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
webpack.config.cjs Removed babylon bootstrap script from build configuration
src/runtime/content_manager.cpp Removed installation of babylon bootstrap scripts
src/client/per_process.cpp Removed babylon bootstrap script from Node.js process arguments
src/client/dom/runtime_context.cpp Added fallback base URI handling for empty values
src/client/dom/document.cpp Added warning messages for invalid URLs
src/client/dom/browsing_context.hpp Enhanced document creation API with base URI parameter
src/bindings/dom/browsing_context.cpp Updated document creation to handle base URI parameter
package.json Removed babylonjs and @yodaos-jsar/dom dependencies, added WebXR types
lib/webxr.ts Removed explicit XRSystem type annotations
lib/webworkers/entry.ts Updated ResourceLoader import path
lib/runtime2/viewers/model3d.ts Converted from XSML to standard HTML format
lib/runtime2/viewers/image2d.ts Converted from XSML to standard HTML format
lib/runtime2/jsardom/xr/motionController/*.ts Removed all Babylon.js-dependent WebXR motion controller files
lib/runtime2/jsardom/xr/features/*.ts Removed all Babylon.js-dependent WebXR feature files

@yorkie yorkie merged commit c1d2dae into main Aug 18, 2025
2 checks passed
@yorkie yorkie deleted the remove/jsardom branch August 18, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants