fix: improve session management #9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves session management in MCPCat with several key enhancements:
track()is called multiple timeslistToolsTracingSetupto work correctly with multiple server instancesTechnical Changes
Session Management
getServerSessionId()to accept optionalextraparameter containing MCP sessionIdderiveSessionIdFromMCPSession()to create deterministic KSUIDs from MCP sessionIdssessionSourcefield to track whether session is MCP or MCPCat-generatedlastMcpSessionIdtracking to detect session changesIdentity Management
IdentityCacheclass with LRU eviction to persist identities across server restartsUserSessionCachefor user reconnection supporthandleIdentify()function ininternal.tsServer Instance Management
track()to prevent duplicate initializationlistToolsTracingSetupfrom boolean to WeakMap for per-instance trackingTest Coverage
Added comprehensive test suite in
src/tests/session-id.test.tscovering:Updated
src/tests/identify.test.tsto reflect new session separation behavior for different users.Breaking Changes
None - all changes are backward compatible. If no MCP sessionId is provided, behavior falls back to the previous MCPCat-generated session logic.