Skip to content

Continuous Benchmarking [Addendum] #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Continuous Benchmarking [Addendum] #1034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
rm -rf ../www/*
mv build/install/docs/mfc/* ../www/
git -C ../www add -A
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a comment to explain why documentation/data.js is being restored. Based on the PR description, this file contains historic benchmark data that should be preserved across documentation deployments. A brief comment would improve maintainability and help future developers understand this special handling.

Example:

# Preserve historic benchmark data from continuous benchmarking (see #1033)
git -C ../www restore documentation/data.js || true
Suggested change
git -C ../www add -A
git -C ../www add -A
# Preserve historic benchmark data from continuous benchmarking (see #1033)

Copilot uses AI. Check for mistakes.
git -C ../www restore documentation/data.js
Comment on lines 71 to +72
Copy link
Contributor

@qodo-merge-pro qodo-merge-pro bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Move the git restore command before git add -A to ensure changes to documentation/data.js are correctly discarded before being staged for commit. [possible issue, importance: 9]

Suggested change
git -C ../www add -A
git -C ../www restore documentation/data.js
git -C ../www restore documentation/data.js
git -C ../www add -A

Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git restore command will fail if documentation/data.js doesn't exist in the git history of the ../www repository (e.g., during initial setup or if the file hasn't been pushed yet). Since set -e is enabled on line 65, this will cause the workflow to fail.

Consider adding error handling to gracefully handle the case where the file doesn't exist:

git -C ../www restore documentation/data.js || true

Alternatively, check if the file exists in the git history before attempting to restore it:

git -C ../www ls-files --error-unmatch documentation/data.js &>/dev/null && git -C ../www restore documentation/data.js || true
Suggested change
git -C ../www restore documentation/data.js
git -C ../www restore documentation/data.js || true

Copilot uses AI. Check for mistakes.
git -C ../www commit -m "Docs @ ${GITHUB_SHA::7}" || true
git -C ../www push

Expand Down