-
Notifications
You must be signed in to change notification settings - Fork 121
readme #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme #1049
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
| Alternatively, run MFC directly with Docker on your local machine: | ||
| ```bash | ||
| docker run -it --rm --entrypoint bash sbryngelson/mfc:latest-cpu | ||
| ``` | ||
| Once inside the container, navigate to `/opt/MFC` to access MFC and run examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Modify the docker run command to mount the current host directory as a volume inside the container. This will persist any generated files on the user's machine after the container exits. [general, importance: 7]
| Alternatively, run MFC directly with Docker on your local machine: | |
| ```bash | |
| docker run -it --rm --entrypoint bash sbryngelson/mfc:latest-cpu | |
| ``` | |
| Once inside the container, navigate to `/opt/MFC` to access MFC and run examples. | |
| Alternatively, run MFC directly with Docker on your local machine. This command mounts your current directory into the container at `/work` so that any generated files are saved on your machine: | |
| ```bash | |
| docker run -it --rm -v "$(pwd)":/work -w /work --entrypoint bash sbryngelson/mfc:latest-cpu |
Once inside the container, you can copy examples from /opt/MFC/examples to your current directory (/work), run them, and the output will appear on your host machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Docker container instructions to the README, providing users with an additional quick-start path alongside the existing Codespaces option.
- Added Docker run command to the "Try MFC" quick reference table
- Expanded "Codespaces and Containers" section with detailed Docker instructions and navigation guidance
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
|
||||||||||||||||||||||
User description
add containers to readme
PR Type
Documentation
Description
Add Docker container option to quick start guide
Include Docker command in installation methods table
Provide instructions for running MFC locally with Docker
Diagram Walkthrough
File Walkthrough
README.md
Add Docker container setup documentationREADME.md
with command
docker run -it --rm --entrypoint bashsbryngelson/mfc:latest-cpuuser's machine
/opt/MFCdirectory inside thecontainer to access MFC and examples