Skip to content

Conversation

@sbryngelson
Copy link
Member

@sbryngelson sbryngelson commented Nov 29, 2025

User description

User description

Add step to set up Python 3.14 in the workflow


PR Type

Enhancement


Description

  • Add Python 3.14 setup step to lint-toolchain workflow

  • Uses actions/setup-python@v5 action for configuration

  • Positioned before MFC Python setup initialization


Diagram Walkthrough

flowchart LR
  checkout["Checkout code"] --> python["Set up Python 3.14"] --> mfc["MFC Python setup"] --> lint["Lint toolchain"]
Loading

File Walkthrough

Relevant files
Configuration changes
lint-toolchain.yml
Add Python 3.14 setup step to workflow                                     

.github/workflows/lint-toolchain.yml

  • Added new step to set up Python 3.14 using actions/setup-python@v5
  • Configured with python-version: '3.14'
  • Inserted after checkout step and before MFC Python setup
+5/-0     


CodeAnt-AI Description

Install Python 3.14 before lint toolchain checks

What Changed

  • The lint workflow now sets up Python 3.14 right after checkout so the following setup and linting steps run with that interpreter
  • MFC's initialization and lint commands continue immediately after the explicit Python installation

Impact

✅ Consistent lint results
✅ Predictable Python environment during lint
✅ Clear Python version selection for toolchain

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Add step to set up Python 3.14 in the workflow
Copilot AI review requested due to automatic review settings November 29, 2025 04:51
@codeant-ai
Copy link

codeant-ai bot commented Nov 29, 2025

CodeAnt AI is reviewing your PR.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sbryngelson-patch-1

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Issue

Python 3.14 is not yet generally available on GitHub-hosted runners; the setup action may fail to find or install it. Consider using the latest stable 3.x (e.g., 3.12/3.13) or a matrix, and/or pin to '3.14-dev' if intentionally targeting pre-release with 'allow-prereleases: true'.

- name: Set up Python 3.14
  uses: actions/setup-python@v5
  with:
    python-version: '3.14'
Workflow Robustness

If MFC Python setup expects a specific version, ensure PATH and caching from setup-python are actually used and compatible, or explicitly specify 'cache: pip' and 'check-latest: true' to avoid stale environments.

- name: Set up Python 3.14
  uses: actions/setup-python@v5
  with:
    python-version: '3.14'

- name: MFC Python setup
  run: ./mfc.sh init

Comment on lines +13 to +16
- name: Set up Python 3.14
uses: actions/setup-python@v5
with:
python-version: '3.14'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Add cache: 'pip' to the actions/setup-python step to enable dependency caching. This will improve workflow performance by restoring dependencies from a cache instead of reinstalling them on each run. [general, importance: 7]

Suggested change
- name: Set up Python 3.14
uses: actions/setup-python@v5
with:
python-version: '3.14'
- name: Set up Python 3.14
uses: actions/setup-python@v5
with:
python-version: '3.14'
cache: 'pip'

@codeant-ai codeant-ai bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Nov 29, 2025
@codeant-ai
Copy link

codeant-ai bot commented Nov 29, 2025

CodeAnt AI finished reviewing your PR.

@sbryngelson sbryngelson merged commit 9adbfb6 into linter Nov 29, 2025
42 checks passed
@sbryngelson sbryngelson deleted the sbryngelson-patch-1 branch November 29, 2025 04:53
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copilot finished reviewing on behalf of sbryngelson November 29, 2025 04:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the lint-toolchain workflow by explicitly setting up Python 3.14 before running MFC's Python-based linting tools. This ensures consistency with the test workflow and pins the Python version for more predictable CI behavior.

Key Changes:

  • Added Python 3.14 setup step using actions/setup-python@v5 before MFC initialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review effort 1/5 size:XS This PR changes 0-9 lines, ignoring generated files

Development

Successfully merging this pull request may close these issues.

2 participants