Example case for 3D turbulent mixing layer #133
Conversation
hyeoksu-lee
commented
Mar 25, 2023
hyeoksu-lee
commented
|
aside from my comments above, you should also add documentation about these input parameters (and how to use them) in https://github.com/MFlowCode/MFC/blob/master/docs/documentation/case.md |
| + (1d0 - eta)*orig_prim_vf(i + cont_idx%end)) | ||
| end do | ||
|
|
||
| if (vel_profile) then |
There was a problem hiding this comment.
please indent this correctly
There was a problem hiding this comment.
please use a comment to describe what this is doing
|
|
||
| parallel_io = .false. | ||
| precision = 2 | ||
| vel_profile = .false. |
There was a problem hiding this comment.
please indent this correctly
| integer :: precision !< Precision of output files | ||
|
|
||
| ! Hypertangent velocity profile | ||
| logical :: vel_profile |
There was a problem hiding this comment.
please indent this correctly
There was a problem hiding this comment.
this isn't how you use doxygen. please use follow the pattern above, like so: logical :: vel_profile !< Hypertangent velocity profile
|
|
||
| end subroutine s_perturb_surrounding_flow ! ---------------------------- | ||
|
|
||
| subroutine s_superposition_instability_wave() ! ------------------------------ |
There was a problem hiding this comment.
does this only work in 2D or 3D? if so, this should be added to the startup checks in m_checker.f90 (or whatever the file is called) so that you cannot run instability_wave on a 1D problem.
There was a problem hiding this comment.
Yes, this is only work in 2D and 3D. I added checks in m_checker.f90 to prevent running on a 1D case.
| ci=0d0 | ||
| do j=0,n | ||
| ii = 1; jj = 1; br((ii-1)*(n+1)+j,(jj-1)*(n+1)+j) = alpha*u_mean(j); | ||
| ii = 1; jj = 2; br((ii-1)*(n+1)+j,(jj-1)*(n+1)+j) = alpha*rho_mean(j); |
|
|
||
| end subroutine s_instability_wave | ||
|
|
||
| subroutine generate_wave(nl,vnr,vni,alpha,beta,wave,shift) |
There was a problem hiding this comment.
I added documentation on it.
| integer i,j,k | ||
|
|
||
| do i=0,m | ||
| do j=0,n |
| ! 6) cdiv | ||
| ! 7) pythag | ||
| !==================================================================== | ||
| subroutine cg(nm,nl,ar,ai,wr,wi,zr,zi,fv1,fv2,fv3,ierr) |
There was a problem hiding this comment.
these routines should live in a separate module so they do not pollute this one. probably in the commmon/ directory.
There was a problem hiding this comment.
All subroutines for solving the eigenvalue problem are moved to m_eigen_solver.f90 in common directory.
…o prevent the use of vel_profile and instability_wave in 1D case
|
Please add documentation about this feature in https://github.com/MFlowCode/MFC/blob/master/docs/documentation/case.md?rgh-link-date=2023-03-26T18%3A06%3A29Z |
I updated case.md file to include documentation about the new feature. |
2 participants
