Skip to content

Fix preempt on Phoenix, add Frontier walltime #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025
Merged

Fix preempt on Phoenix, add Frontier walltime #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/frontier/submit-bench.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ sbatch <<EOT
#SBATCH -A CFD154 # charge account
#SBATCH -N 1 # Number of nodes required
$sbatch_device_opts
#SBATCH -t 01:59:00 # Duration of the job (Ex: 15 mins)
#SBATCH -t 02:59:00 # Duration of the job (Ex: 15 mins)
#SBATCH -o$job_slug.out # Combined output and error messages file
#SBATCH -p extended # Extended partition for shorter queues
#SBATCH -W # Do not exit until the submitted job terminates.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/frontier/submit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ sbatch <<EOT
#SBATCH -A CFD154 # charge account
#SBATCH -N 1 # Number of nodes required
$sbatch_device_opts
#SBATCH -t 01:59:00 # Duration of the job (Ex: 15 mins)
#SBATCH -t 02:59:00 # Duration of the job (Ex: 15 mins)
#SBATCH -o$job_slug.out # Combined output and error messages file
#SBATCH -p extended # Extended partition for shorter queues
#SBATCH -W # Do not exit until the submitted job terminates.
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/phoenix/submit-bench.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ JOBID=$(sbatch <<-EOT | awk '{print $4}'
EOT
)

echo "🚀 Submitted SLURM job $JOBID"
echo "Submitted: SLURM job $JOBID"

# if this wrapper is killed/canceled, make sure SLURM job is cleaned up
trap '[[ -n "${JOBID:-}" ]] && scancel "$JOBID" >/dev/null 2>&1 || :' EXIT
Expand All @@ -86,22 +86,22 @@ while :; do

# If it’s one of SLURM’s terminal states, break immediately
case "$STATE" in
COMPLETED|FAILED|CANCELLED|TIMEOUT)
echo "✅ SLURM job $JOBID reached terminal state: $STATE"
COMPLETED|FAILED|CANCELLED|TIMEOUT|PREEMPTED)
echo "Completed: SLURM job $JOBID reached terminal state: $STATE"
break
;;
"")
echo "✅ SLURM job $JOBID no longer in queue; assuming finished"
echo "Completed: SLURM job $JOBID no longer in queue; assuming finished"
break
;;
*)
echo "⏳ SLURM job $JOBID state: $STATE"
echo "Waiting: SLURM job $JOBID state: $STATE"
sleep 10
;;
esac
done

# Now retrieve the exit code and exit with it
EXIT_CODE=$(sacct -j "$JOBID" --noheader --format=ExitCode | head -1 | cut -d: -f1)
echo "🔚 SLURM job $JOBID exit code: $EXIT_CODE"
echo "Completed: SLURM job $JOBID exit code: $EXIT_CODE"
exit "$EXIT_CODE"
12 changes: 6 additions & 6 deletions .github/workflows/phoenix/submit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ JOBID=$(sbatch <<-EOT | awk '{print $4}'
EOT
)

echo "🚀 Submitted SLURM job $JOBID"
echo "Submitted: SLURM job $JOBID"

# if this wrapper is killed/canceled, make sure SLURM job is cleaned up
trap '[[ -n "${JOBID:-}" ]] && scancel "$JOBID" >/dev/null 2>&1 || :' EXIT
Expand All @@ -79,22 +79,22 @@ while :; do

# If it’s one of SLURM’s terminal states, break immediately
case "$STATE" in
COMPLETED|FAILED|CANCELLED|TIMEOUT)
echo "✅ SLURM job $JOBID reached terminal state: $STATE"
COMPLETED|FAILED|CANCELLED|TIMEOUT|PREEMPTED)
echo "Completed: SLURM job $JOBID reached terminal state: $STATE"
break
;;
"")
echo "✅ SLURM job $JOBID no longer in queue; assuming finished"
echo "Completed: SLURM job $JOBID no longer in queue; assuming finished"
break
;;
*)
echo "⏳ SLURM job $JOBID state: $STATE"
echo "Waiting: SLURM job $JOBID state: $STATE"
sleep 10
;;
esac
done

# Now retrieve the exit code and exit with it
EXIT_CODE=$(sacct -j "$JOBID" --noheader --format=ExitCode | head -1 | cut -d: -f1)
echo "🔚 SLURM job $JOBID exit code: $EXIT_CODE"
echo "Completed: SLURM job $JOBID exit code: $EXIT_CODE"
exit "$EXIT_CODE"
Loading