Skip to content

Conversation

@alexrayne
Copy link

@alexrayne alexrayne commented Mar 25, 2023

There provided fresh run-time FPC Lazarus package, that well builds on win10x64 with lazarus 2.3 fpc 3.2.2

  • FPC package and code resides in fpc/ folder

  • starts asm code extracting on -> machine-dependent sources, with FPC-stylec directory structure: x86/ and x86_64/ dirs are CPU-targets

  • problems: FPC planed lambdas on ver3.3. So TDECProgressEvent still maybe only procedure

alexrayne added 2 commits March 25, 2023 22:18
* starts  asm code extracting on -> machine-dependent sources, with FPC-stylec directory structure:
        x86/ and x86_64/ dirs are CPU-targets

* problems: FPC planed lambdas on ver3.3. So  TDECProgressEvent still maybe only procedure
@MHumm
Copy link
Owner

MHumm commented Apr 8, 2023

Thanks for this pull request! I try to have a look at the code soon, but:

  1. Can you please change it so that this is for development branch instead of master branch? I want to have such contributions in development branch first.
  2. I'm not 100% sure yet what the benefit will be (maybe when I look at the code): it creates packages for DEC so it can be used as package?
  3. Be aware please that I don't use FPC and while I value and like FPC compatibility, I cannot test FPC stuff (ok, I could install it and test on Windows at least, but my time is unfortunately limited as well). So it would be nice if somebody could change such FPC related stuff now and then to make sure we don't break any of it when further working on DEC.

@alexrayne
Copy link
Author

alexrayne commented Apr 8, 2023

  1. As i unwerstand git, there no matter where i base PR, it's is your desigin - where to merge it. Should i still rebase this PR on to develop?

  2. Yep, this is runtime package for lazarus IDE. old lazarus package source/DEC60Lazarus.lpk provided for fpc2 - that is ancient legacy, totaly incompatible with modern Deplhi, and even modern FPC

  3. as for testing, FPC provides wide range of OS and CPU targets. that is huge work to test them all. imho, you beter rely this work on users )/ You better test Deplhi packages, since i have no Delphi, and can`t test Embarcadero packages

Copy link
Owner

@MHumm MHumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only things I don't really understand yet are these x86 and x64 includes with the swap routines. It would be good to have unit tests for those as well. Can you add some?

MHumm added a commit that referenced this pull request Oct 21, 2023
@alexrayne
Copy link
Author

alexrayne commented Oct 23, 2023

there alredy test project in repo, that imports and builds well with lazarus. I`ve run it on x86_64, so looks it tested

@MHumm MHumm merged commit c49312b into MHumm:master Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants