Update Makefile and GHA Dev1 Workflow #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: After some initial testing by the developer, we are moving the control of the ECR Repository for this function into the hands of Infra through the mitlib-tf-workloads-ecr repository. That repository generates the correct Makefile commands for the developer to push containers to the managed ECR Repository and update the associated Lambda function. How this addresses that need: * Update the Makefile with the output from mitlib-tf-workloads-ecr * Create a new dev-build.yml GitHub Actions workflow using the output from mitlib-tf-workloads-ecr Side effects of this change: None. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-1011
|
@jonavellecuerdo |
jonavellecuerdo
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How this addresses that need:
Side effects of this change:
None.
Relevant ticket(s):
Purpose and background context
After some initial testing by the developer, we are moving the control of the ECR Repository for this function into the hands of Infra through the mitlib-tf-workloads-ecr repository. That repository generates the correct Makefile commands for the developer to push containers to the managed ECR Repository and update the associated Lambda function.
How can a reviewer manually see the effects of these changes?
The developer can use the
makecommands (make dist-dev&make publish-dev) in the updated Makefile to verify that it is possible to push a container image to the new ECR Repository. The Lambda commands will not work yet since Infra has not yet deployed the Lambda infrastructure.Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)