Skip to content

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented Jan 11, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.41.0 → 1.43.0) · Repo · Changelog

Release Notes

1.43.0

New features

Bug fixes

  • #11386: Fix a false positive for Style/OperatorMethodCall when using anonymous forwarding. (@koic)
  • #11409: Fix an incorrect autocorrect for Style/HashSyntax when using hash value omission and EnforcedStyle: no_mixed_keys. (@koic)
  • #11405: Fix undefined method `range_between' for Style/WhileUntilModifier. (@such)
  • #11374: Fix an error for Style/StringHashKeys when using invalid symbol in encoding UTF-8 as keys. (@koic)
  • #11392: Fix an incorrect autocorrect for Style/RedundantDoubleSplatHashBraces using double splat in double splat hash braces. (@koic)
  • #8990: Make Style/HashEachMethods aware of built-in Thread.current. (@koic)
  • #11390: Fix an incorrect autocorrect for Style/HashSyntax when hash first argument key and hash value only are the same which has a method call on the next line. (@koic)
  • #11379: Fix a false negative for Style/OperatorMethodCall when using a.+ b.something. (@koic)
  • #11180: Fix an error for Style/RedundantRegexpEscape when using %r to provide regexp expressions. (@si-lens)
  • #11403: Fix bad offense for parenthesised calls in literals for omit_parentheses style in Style/MethodCallWithArgsParentheses. (@gsamokovarov)
  • #11407: Fix an error for Style/HashSyntax when expression follows hash key assignment. (@fatkodima)
  • #11377: Fix Style/OperatorMethodCall when forwarding arguments. (@sambostock)

Changes

  • #11382: Require unicode-display_width 2.4.0 or higher. (@fatkodima)
  • #11381: Require Parser 3.2.0.0 or higher. (@koic)
  • #11380: Disable Style/YodaExpression by default. (@koic)
  • #11303: Make Metrics/ParameterLists aware of Struct.new and Data.define blocks. (@koic)

1.42.0

New features

Bug fixes

  • #11204: Fix a false negative for Lint/RedundantCopDisableDirective when using --except command line option. (@koic)
  • #11369: Fix an error for Lint/UselessRuby2Keywords when using Proc#ruby2_keywords. (@koic)
  • #11351: Fix an incorrect autocorrect for Lint/RegexpAsCondition when using regexp literal with bang. (@koic)
  • #11329: Accept simple freezed constants in Layout/ClassStructure and correctly handle class methods. (@fatkodima)
  • #11344: Fix an error for Style/GuardClause when using heredoc as an argument of raise in then branch and it does not have else branch. (@koic)
  • #11335: Fix an error for Style/RequireOrder when only one reuqire. (@koic)
  • #11348: Fix an error for Style/SelectByRegexp when block body is empty. (@koic)
  • #11320: Fix a false positive for Lint/RequireParentheses when assigning ternary operator. (@koic)
  • #11361: Make Style/MethodDefParentheses aware of Ruby 3.2's anonymous rest and keyword rest arguments. (@koic)
  • #11346: Fix a false positive for Style/RedundantStringEscape when using escaped space in heredoc. (@koic)
  • #10858: Fix Style/IdenticalConditionalBranches to ignore identical leading lines when branch has single child and is used in return context. (@fatkodima)
  • #11237: Fix Layout/CommentIndentation comment aligned with access modifier indentation when EnforcedStyle is outdent. (@soroktree)
  • #11330: Fix an error for Style/RequireOrder when using require inside rescue body. (@fatkodima)
  • #8751: Accept super within ranges for Layout/SpaceAroundKeyword cop. (@fatkodima)
  • #10194: Accept bracketed arrays within 2d arrays containing subarrays with complex content for Style/WordArray cop. (@fatkodima)

Changes

  • #8366: Ignore private constants in Layout/ClassStructure cop. (@fatkodima)
  • #11325: Support autocorrection for percent literals in Style/ConcatArrayLiterals. (@fatkodima)
  • #11327: Make Style/ZeroLengthPredicate aware of array.length.zero?. (@koic)
  • #10976: Support pattern matching for Lint/OutOfRangeRegexpRef cop. (@fatkodima)

1.41.1

Bug fixes

  • #11293: Fix a false negative for Style/Documentation when using macro. (@koic)
  • #11313: Fix a false positive for Naming/BlockForwarding when the block argument is reassigned. (@fatkodima)
  • #11014: Fix a false positive for Style/Aliascop when alias in a method def. (@ydah)
  • #11309: Fix a false positive for Style/RedundantStringEscape when using a redundant escaped string interpolation \#\{foo}. (@koic)
  • #11307: Fix an error for Style/GuardClause when using lvar as an argument of raise in else branch. (@ydah)
  • #11308: Fix disabling departments via comment. (@fatkodima)

Changes

  • #11312: Mark Style/ConcatArrayLiterals as unsafe. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 3.1.3.0 → 3.2.0.0) · Repo · Changelog

Release Notes

3.2.0.0 (from changelog)

API modifications:

  • lexer.rl: extract extend_string_escaped to a separate method (#893) (Ilya Bylich)
  • bump Racc to 1.6.1 (#890) (Koichi ITO)

Features implemented:

  • lexer.rl: use Ragel -F0 on non-CRuby (#894) (Benoit Daloze)
  • ruby32.y: Allow optional newlines before closing parenthesis (#892) (Koichi ITO)

Bugs fixed:

  • ruby32.y: fix a parse error when using forwarded argument with restarg (#889) (Koichi ITO)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 14 commits:

↗️ rubocop-ast (indirect, 1.24.0 → 1.24.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 8 commits:

↗️ unicode-display_width (indirect, 2.3.0 → 2.4.2) · Repo · Changelog

Release Notes

2.4.2 (from changelog)

More performance improvements:

  • Optimize lookup of first 4096 codepoints
  • Avoid overwrite lookup if no overwrites are set

2.4.1 (from changelog)

  • Improve general performance!
  • Further improve performance for ASCII strings

You should really upgrade - it's much faster now!

2.4.0 (from changelog)

  • Improve performance for ASCII-only strings, by @fatkodima
  • Require Ruby 2.4

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 20 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jan 11, 2023
@mitlib mitlib temporarily deployed to mit-bento-pr-1133 January 11, 2023 11:56 Inactive
@coveralls
Copy link

Coverage Status

Coverage: 99.197%. Remained the same when pulling 2ce3d78 on depfu/update/rubocop-1.43.0 into f62cf4d on main.

@depfu
Copy link
Contributor Author

depfu bot commented Jan 24, 2023

Closed in favor of #1136.

@depfu depfu bot closed this Jan 24, 2023
@depfu depfu bot deleted the depfu/update/rubocop-1.43.0 branch January 24, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants