Skip to content

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented Apr 17, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.18.0 → 2.19.1) · Repo · Changelog

Release Notes

2.19.1

Bug fixes

  • #979: Fix an error for Rails/ThreeStateBooleanColumn when using t.boolean in drop_table. (@koic)

2.19.0

New features

  • #337: Add new Rails/ThreeStateBooleanColumn cop. (@fatkodima)
  • #45: Make Rails/Delegate aware of self. (@koic)

Bug fixes

  • #934: Fix a false negative for Rails/Output when print methods without arguments. (@koic)
  • #99: Fix a false positive for Rails/HttpPositionalArguments when using include Rack::Test::Methods. (@koic)
  • #501: Fix a false positive for Rails/OutputSafety when using html_safe for I18n methods. (@koic)
  • #860: Fix a false positive for Rails/Pluck when using regexp literal key for String#[]. (@koic)
  • #938: Fix an error for Rails/WhereNotWithMultipleConditions when using where.not.lt(condition) as a Mongoid API'. (@koic)
  • #941: Remove redundant config for Style/InverseMethods. (@koic)

Changes

  • #299: Add autocorrection for Rails/ReflectionClassName. (@tejasbubane)
  • #34: Allow CreateTableWithTimestamps when using id: false and not include timestamps. (@koic)
  • #694: Mark Rails/FindEach as unsafe. (@koic)
  • #940: Mark Rails/ResponseParsedBody as unsafe. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 62 commits:

✳️ rubocop (1.48.1 → 1.50.1) · Repo · Changelog

Release Notes

1.50.1

Bug fixes

  • #11787: Fix a false positive for Lint/DuplicateMatchPattern when repeated in patterns but different if guard is used. (@koic)
  • #11789: Fix false negatives for Style/ParallelAssignment when Ruby 2.7+. (@koic)
  • #11783: Fix a false positive for Style/RedundantLineContinuation using line concatenation for assigning a return value and without argument parentheses. (@koic)

1.50.0

New features

  • #11749: Add new Lint/DuplicateMatchPattern cop. (@koic)
  • #11773: Make Layout/ClassStructure aware of singleton class. (@koic)
  • #11779: Make Lint/RedundantStringCoercion aware of print method arguments. (@koic)
  • #11776: Make Metrics/ClassLength aware of singleton class. (@koic)
  • #11775: Make Style/TrailingBodyOnClass aware of singleton class. (@koic)

Bug fixes

  • #11758: Fix a false positive for Style/RedundantLineContinuation when line continuations for string. (@koic)
  • #11754: Fix a false positive for Style/RedundantLineContinuation when using && and || with a multiline condition. (@ydah)
  • #11765: Fix an error for Style/MultilineMethodSignature when line break after def keyword. (@koic)
  • #11762: Fix an incorrect autocorrect for Style/ClassEqualityComparison when comparing a variable or return value for equality. (@koic)
  • #11752: Fix a false positive for Style/RedundantLineContinuation when using line concatenation and calling a method without parentheses. (@koic)

1.49.0

New features

  • #11122: Add new Style/RedundantLineContinuation cop. (@ydah)
  • #11696: Add new Style/DataInheritance cop. (@ktopolski)
  • #11746: Make Layout/EndAlignment aware of pattern matching. (@koic)
  • #11750: Make Metrics/BlockNesting aware of numbered parameter. (@koic)
  • #11699: Make Style/ClassEqualityComparison aware of Class#to_s and Class#inspect for class equality comparison. (@koic)
  • #11737: Make Style/MapToHash and Style/MapToSet aware of numbered parameters. (@koic)
  • #11732: Make Style/MapToHash and Style/MapToSet aware of symbol proc. (@koic)
  • #11703: Make Naming/InclusiveLanguage support autocorrection when there is only one suggestion. (@koic)

Bug fixes

  • #11730: Fix an error for Layout/HashAlignment when using anonymous keyword rest arguments. (@koic)
  • #11704: Fix a false positive for Lint/UselessMethodDefinition when method definition with non access modifier containing only super call. (@koic)
  • #11723: Fix a false positive for Style/IfUnlessModifier when using one-line pattern matching as a if condition. (@koic)
  • #11725: Fix an error when insufficient permissions to server cache dir are granted. (@koic)
  • #11715: Ensure default configuration loads. (@koic)
  • #11742: Fix error handling in bundler standalone mode. (@composerinteralia)
  • #11712: Fix a crash in Lint/EmptyConditionalBody. (@gsamokovarov)
  • #11641: Fix a false negative for Layout/ExtraSpacing when there are many comments with extra spaces. (@nobuyo)
  • #11740: Fix a false positive for Lint/NestedMethodDefinition when nested definition inside *_eval and *_exec method call with a numblock. (@ydah)
  • #11685: Fix incorrect directive comment insertion when percent array violates Layout/LineLength cop. (@nobuyo)
  • #11706: Fix infinite loop when --disable-uncorrectable option and there is a multi-line percent array violates Layout/LineLength. (@nobuyo)
  • #11697: Fix Lint/Syntax behavior when --only is not given the cop name. (@koic)
  • #11709: Fix value omission false positive in Style/MethodCallWithArgsParentheses. (@gsamokovarov)

Changes

  • #11739: Make Style/RedundantParentheses aware of redundant method argument parentheses. (@koic)
  • #10766: Use the path given by --cache-root to be the parent for rubocop_cache dir like other ways to specify it. (@nobuyo)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 3.2.1.1 → 3.2.2.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 6 commits:

↗️ rubocop-ast (indirect, 1.27.0 → 1.28.0) · Repo · Changelog

Release Notes

1.28.0 (from changelog)

New features

  • #259: Add forwarded_kwrestarg node to AST::Builder. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 5 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Apr 17, 2023
@mitlib mitlib temporarily deployed to mit-bento-pr-1175 April 17, 2023 05:46 Inactive
@github-actions
Copy link

Coverage Status

Coverage: 99.216%. Remained the same when pulling 4ab7298 on depfu/update/rubocop-rails-2.19.1 into 6e078d2 on main.

@depfu
Copy link
Contributor Author

depfu bot commented Apr 28, 2023

Closing because this update has already been applied

@depfu depfu bot closed this Apr 28, 2023
@depfu depfu bot deleted the depfu/update/rubocop-rails-2.19.1 branch April 28, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants