Skip to content

Removes unnecessary info from feedback email #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Removes unnecessary info from feedback email #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/views/feedback_mailer/feedback_email.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
<p>The following feedback was submitted.</p>

<p><%= @msg %></p>
<p><%= @msg %></p>

<p>Contact Name: <%= @contact_name %></p>

Expand Down
2 changes: 0 additions & 2 deletions test/controllers/feedback_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ class FeedbackControllerTest < ActionDispatch::IntegrationTest

assert_equal('MIT Bento Feedback', feedback_email.subject)
assert_equal('test@example.com', feedback_email.to[0])
assert_match(/The following feedback was submitted/,
feedback_email.body.to_s)
assert_match(/Popcorn is cool./,
feedback_email.body.to_s)
assert_match(/Client IP: 127.0.0.1/,
Expand Down
4 changes: 1 addition & 3 deletions test/fixtures/feedback_mailer/feedback_email
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@
</head>

<body>
<p>The following feedback was submitted.</p>

<p>This is an important message!</p>
<p>This is an important message!</p>

<p>Contact Name: Firsty Lastoson</p>

Expand Down