Wrap 404s in site template #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage remained the same at 100.0% when pulling 0f9122fa90706abf9c510dbc3432c5618af2342c on 249_custom_error_handling into b8c5096 on master. |
frrrances
reviewed
Mar 10, 2017
Contributor
frrrances
left a comment
frrrances
left a comment
There was a problem hiding this comment.
One small change... otherwise looks good.
Contributor
There was a problem hiding this comment.
Can you add class="title title-page" to this h2?
JPrevost
force-pushed
the
249_custom_error_handling
branch
from
0f9122f to
f6ee7cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just puts the 404s in our site template for now.
5xx is less simple due to the nature of 5xx meaning it's best to use static pages so we need to do more work.