split up the scss #162
Merged
split up the scss #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrrances
force-pushed
the
frances/enhance/split-scss
branch
from
af613b9 to
e37a71c
Compare
frrrances
force-pushed
the
frances/enhance/split-scss
branch
from
e37a71c to
995fb3d
Compare
|
Coverage remained the same at 100.0% when pulling 995fb3d87820e5721293bc253c4952d517d3aa29 on frances/enhance/split-scss into 461416a on master. |
frrrances
force-pushed
the
frances/enhance/split-scss
branch
from
995fb3d to
c7e3051
Compare
JPrevost
approved these changes
Mar 23, 2017
Member
JPrevost
left a comment
JPrevost
left a comment
There was a problem hiding this comment.
I flagged a couple of spots that aren't using variable color names. I really don't care and I think there are probably more in non-changed bits of the scss.
Also, thanks for return the 🌈 !
| font-weight: 600; | ||
| } | ||
| form .field-label.error { | ||
| color: #AC1D22; |
Member
There was a problem hiding this comment.
Flagging in case you wanted to variable this. I don't care, but I think you might? :)
| box-shadow: 0 0 5px rgba(14, 166, 236, 0.8); | ||
| } | ||
| form .field.error { | ||
| border-color: #AC1D22; |
Contributor
Author
There was a problem hiding this comment.
those get generated out of the style-guide repo so imma leave em.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the scss files for bento into reasonable pieces.